Removing original author's name

Just scream. We know you want to.
Forum rules
There will be no censorship here. There is no government here. There is only freedom.

Removing original author's name

Postby red1 » Thu Sep 08, 2011 3:33 am

Here at this link http://adempiere.hg.sourceforge.net/hgw ... 919bf50f30
I paste the code diff which shows the removal of an author's name and replaced by another when the code change is not entire but still rely on the original author's work. Is this just and legit? Can the new code now reflect the new author as the sole author or just a subsequent contributor? If so, wouldn't it be better that way? How do we protect an original copyrighted work?

To who can we raise this issue? PMC Head? I paste below in case that links is lost:

Code: Select all

     1.1 --- a/zkwebui/WEB-INF/src/org/adempiere/webui/AdempiereIdGenerator.java   Mon Jul 25 15:22:31 2011 -0500
     1.2 +++ b/zkwebui/WEB-INF/src/org/adempiere/webui/AdempiereIdGenerator.java   Tue Jul 26 13:43:13 2011 -0500
     1.3 @@ -1,6 +1,6 @@
     1.4  /******************************************************************************
     1.5 - * Copyright (C) 2010 Carlos Ruiz                                             *
     1.6 - * Copyright (C) 2009 Quality Systems & Solutions - globalqss                 *
     1.7 + * Copyright (C) 2011 victor.perez@e-evolution.com                            *
     1.8 + * Copyright (C) 2009 www.e-evolution.com, e-Evolution                         *
     1.9   * This program is free software; you can redistribute it and/or modify it    *
    1.10   * under the terms version 2 of the GNU General Public License as published   *
    1.11   * by the Free Software Foundation. This program is distributed in the hope   *
    1.12 @@ -19,34 +19,30 @@
    1.13  import org.zkoss.zk.ui.Page;
    1.14  import org.zkoss.zk.ui.sys.IdGenerator;
    1.15 
    1.16 +/**
    1.17 + * PP Product BOM Model.
    1.18 + *
    1.19 + * @author Victor Perez www.e-evolution.com
    1.20 + * http://docs.zkoss.org/wiki/How_to_Test_ZK_Application_with_Selenium
    1.21 + * */
    1.22 +
    1.23  public class AdempiereIdGenerator implements IdGenerator {
    1.24 -
    1.25 -   @Override
    1.26     public String nextComponentUuid(Desktop desktop, Component comp) {
    1.27 -      String id = (String) comp.getAttribute("zk_component_ID");
    1.28 -      if (id != null && id.length() > 0)
    1.29 -         return id;
    1.30 -      String prefix = (String) comp.getAttribute("zk_component_prefix");
    1.31 -      if (prefix == null || prefix.length() == 0)
    1.32 -         prefix = "zk_comp_";
    1.33 -      int     i = Integer.parseInt(desktop.getAttribute("Id_Num").toString());
    1.34 -      i++;// Start from 1
    1.35 -      desktop.setAttribute("Id_Num", String.valueOf(i));
    1.36 -      return prefix + i;
    1.37 -   }
    1.38 -
    1.39 -   @Override
    1.40 -   public String nextDesktopId(Desktop desktop) {
    1.41 -      if (desktop.getAttribute("Id_Num") == null) {
    1.42 -         String number = "0";
    1.43 -         desktop.setAttribute("Id_Num", number);
    1.44 -      }
    1.45 -      return null;
    1.46 -   }
    1.47 -
    1.48 -   @Override
    1.49 -   public String nextPageUuid(Page page) {
    1.50 -      return null;
    1.51 -   }
    1.52 -
    1.53 +        int i = Integer.parseInt(desktop.getAttribute("Id_Num").toString());
    1.54 +        i++;// Start from 1
    1.55 +        desktop.setAttribute("Id_Num", String.valueOf(i));
    1.56 +        return "zk_comp_" + i;
    1.57 +    }
    1.58 +
    1.59 +    public String nextDesktopId(Desktop desktop) {
    1.60 +        if (desktop.getAttribute("Id_Num") == null) {
    1.61 +            String number = "0";
    1.62 +            desktop.setAttribute("Id_Num", number);
    1.63 +        }
    1.64 +        return null;
    1.65 +    }
    1.66 +
    1.67 +    public String nextPageUuid(Page page) {
    1.68 +        return null;
    1.69 +    }
    1.70  }

red1
Site Admin
 
Posts: 2760
Joined: Tue Jul 06, 2004 3:01 pm
Location: Kuala Lumpur, Malaysia

Re: Removing original author's name

Postby red1 » Wed Oct 12, 2011 4:51 pm

It seems that it is happening to me too http://adempiere.hg.sourceforge.net/hgw ... avaPOS.sql if you follow this and other files after it, the original author which is supposed to me is now different:
vpj-cd victor.perez@e-evolution.com
Thu Sep 01 14:11:36 2011 -0500 (5 weeks ago)


My original work was done here (note the time difference):
Revision: 16031
http://adempiere.svn.sourceforge.net/ad ... 1&view=rev
Author: red1
Date: 2011-08-13 16:26:48 +0000 (Sat, 13 Aug 2011)


I was checking this in Munich, and i got a witness (board member of ADempiere e.V) that i showed the contents comparison to, but you can check for yourself as all submissions are online.

If this is an honest mistake, please rectify. If it is intentional, well i have no comment at this moment.
red1
Site Admin
 
Posts: 2760
Joined: Tue Jul 06, 2004 3:01 pm
Location: Kuala Lumpur, Malaysia

Re: Removing original author's name

Postby red1 » Wed Oct 12, 2011 6:14 pm

I have posted it here http://sourceforge.net/projects/adempie ... dex/page/1 adding that it is probably an honest action, but some statement of credit should be given somewhere.
red1
Site Admin
 
Posts: 2760
Joined: Tue Jul 06, 2004 3:01 pm
Location: Kuala Lumpur, Malaysia

Re: Removing original author's name

Postby red1 » Wed Oct 19, 2011 9:15 pm

I finally spent some time checking the code complaint by Carlos, above and found that Victor only removed some lines and that is it. And the code removed is doing some important null checking. Does that warrant an authorship removal of Carlos name? And the code removed is:

Code: Select all
      String id = (String) comp.getAttribute("zk_component_ID");
        if (id != null && id.length() > 0)
           return id;
          String prefix = (String) comp.getAttribute("zk_component_prefix");
           if (prefix == null || prefix.length() == 0)
              prefix = "zk_comp_";

Truly dumbfounding and atrocious behavior for the present PMC and ADeV board. Otherwise it is shameful.
red1
Site Admin
 
Posts: 2760
Joined: Tue Jul 06, 2004 3:01 pm
Location: Kuala Lumpur, Malaysia

Re: Removing original author's name

Postby globalqss » Wed Oct 19, 2011 10:01 pm

Good research Redhuan, to complement this information:

This line
Code: Select all
String prefix = (String) comp.getAttribute("zk_component_prefix");

is very important on the complete approach worked by former PMC, and documented at
https://sourceforge.net/mailarchive/for ... iere-p-m-c

All the work from PMC was destroyed with a poor copy from zk forums.

Regards,

Carlos Ruiz
globalqss
Senior
 
Posts: 599
Joined: Thu Dec 29, 2005 4:15 am
Location: Bogotá, Colombia

Re: Removing original author's name

Postby red1 » Sat Oct 29, 2011 3:22 am

I found in http://docs.zkoss.org/wiki/How_to_Test_ ... h_Selenium the code which Carlos could have made reference for the idea or pattern. Though it may be original construct added on, i prefer to give some credit to the sources or quote them as i did for another class here:

Code: Select all
/**********************************************************************
* This file is part of Adempiere ERP Bazaar                           *
* http://www.adempiere.org                                            *
*                                                                     *
* Copyright (C) Redhuan D. Oon                                        *
* Copyright (C) Contributors                                          *
*                                                                     *
* This program is free software; you can redistribute it and/or       *
* modify it under the terms of the GNU General Public License         *
* as published by the Free Software Foundation; either version 2      *
* of the License, or (at your option) any later version.              *
*                                                                     *
* This program is distributed in the hope that it will be useful,     *
* but WITHOUT ANY WARRANTY; without even the implied warranty of      *
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the        *
* GNU General Public License for more details.                        *
*                                                                     *
* You should have received a copy of the GNU General Public License   *
* along with this program; if not, write to the Free Software         *
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,          *
* MA 02110-1301, USA.                                                 *
*                                                                     *
* Contributors:                                                       *
* -  Based on the Fitnesse and UISpec4J projects with many thanks     *
* - For support please register in http://www.red1.org/adempiere      *
***********************************************************************/
package GUITest;

import org.uispec4j.Trigger;
import org.uispec4j.Window;
import org.uispec4j.interception.WindowHandler;
import org.uispec4j.interception.WindowInterceptor;
import org.uispec4j.utils.MainClassTrigger;

/*
* This is a fast test to dump the displayed objects in the POS
* Able to return the exception string that contains..
* All buttons, panels and rows of items under Popular or All Products selection
*/
public class DumpGUIObjects extends ModelLogin {
red1
Site Admin
 
Posts: 2760
Joined: Tue Jul 06, 2004 3:01 pm
Location: Kuala Lumpur, Malaysia

Re: Removing original author's name

Postby red1 » Sat Oct 29, 2011 4:19 am

Looking at the more original work on this subject i find WEditor patched as follows:
(CarlosRuiz) -
Code: Select all
Index: zkwebui/WEB-INF/src/org/adempiere/webui/editor/WEditor.java
===================================================================
--- zkwebui/WEB-INF/src/org/adempiere/webui/editor/WEditor.java   (revision 12088)
+++ zkwebui/WEB-INF/src/org/adempiere/webui/editor/WEditor.java   (working copy)
@@ -92,6 +92,7 @@
         }

         this.setComponent(comp);
+        comp.setAttribute("zk_component_ID", "Field_" + gridField.getColumnName() + "_" + gridField.getAD_Tab_ID() + "_" + gridField.getWindowNo());
         this.gridField = gridField;


And in the OSGi variant (HengSin) -
Code: Select all
        comp.setAttribute(AdempiereIdGenerator.ZK_COMPONENT_PREFIX_ATTRIBUTE, "Field_" + gridField.getColumnName() + gridTabName);


For my interest in my present task of reviewing ZK testing, this seems to do different things (which CR and HS variants are not supposed to differ in logic).

Back to the thread discussion, i like to say is that both snips did not change or add to the original author name which is Ashley G Ramdass. By right if this is original work to earn a copyright name over ZK in the IdGenerator class (which is more from ZK), then at least CR and HS be put as co authors or contributors.
red1
Site Admin
 
Posts: 2760
Joined: Tue Jul 06, 2004 3:01 pm
Location: Kuala Lumpur, Malaysia

Re: Removing original author's name

Postby red1 » Sat Oct 29, 2011 4:35 am

Again, comparing same snip with HengSin's, there is more original work in his ADempiereIdGenerator class:
Code: Select all
   public String nextComponentUuid(Desktop desktop, Component comp) {
      String prefix = (String) comp.getAttribute(ZK_COMPONENT_PREFIX_ATTRIBUTE);
      if (prefix == null || prefix.length() == 0)
         prefix = DEFAULT_ZK_COMP_PREFIX;
      else {
         Pattern pattern = Pattern.compile("[^a-zA-Z_0-9]");
         Matcher matcher = pattern.matcher(prefix);
         StringBuffer sb = new StringBuffer();
         while(matcher.find()) {
            matcher.appendReplacement(sb, "_");
         }
         matcher.appendTail(sb);
         prefix = sb.toString();
      }
      int i = 0;
      try {
         String number = null;
         if (desktop.getAttribute(DESKTOP_ID_ATTRIBUTE) != null) {
            number = desktop.getAttribute(DESKTOP_ID_ATTRIBUTE).toString();
            i = Integer.parseInt(number);
            i++;// Start from 1
         }
      } catch (Throwable t) {
         i = 1;
      }
      desktop.setAttribute(DESKTOP_ID_ATTRIBUTE, String.valueOf(i));
      if (!prefix.endsWith("_"))
         prefix = prefix + "_";
      return prefix + i;
   }


Compare this with Carlos' at the top. CR has also passed me HS' Selenium test code which seems to work off his OSGi variant, so i will be incorporating his snips into CR's 361 to test. If this works it can go back into ADempiere with credits to HS, CR and Ivan etc.
red1
Site Admin
 
Posts: 2760
Joined: Tue Jul 06, 2004 3:01 pm
Location: Kuala Lumpur, Malaysia

Re: Removing original author's name

Postby red1 » Sun Oct 30, 2011 8:25 pm

Done that, and there are more classes from iDempiere to copy over to CarlosRuiz361 (by searching for 'AdempiereIdGenerator':

Code: Select all
ADButtonTabList.java - adempiere361/zkwebui/WEB-INF/src/org/adempiere/webui/component (2 matches)
ConfirmPanel.java - adempiere361/zkwebui/WEB-INF/src/org/adempiere/webui/component (2 matches)
CWindowToolbar.java - adempiere361/zkwebui/WEB-INF/src/org/adempiere/webui/component (4 matches)
LoginPanel.java - adempiere361/zkwebui/WEB-INF/src/org/adempiere/webui/panel (4 matches)
RolePanel.java - adempiere361/zkwebui/WEB-INF/src/org/adempiere/webui/panel (5 matches)
TreeSearchPanel.java - adempiere361/zkwebui/WEB-INF/src/org/adempiere/webui/panel (2 matches)
WEditor.java - adempiere361/zkwebui/WEB-INF/src/org/adempiere/webui/editor (2 matches)


Then I rebuild, redeploy, silentsetup, run selenium server and run HS test code, it now works. Thus ZK UI testing is proven on both iDempiere and CR361. Will port this over to the Jenkins server and then document it (with more fuller tests constructed).

However i prefer (trying) in AdempiereIdGenerator to not add the suffix running id so that in Selenium tests we need not
Code: Select all
      selenium.type("//input[starts-with(@id, 'txtUserId_')]", "SuperUser");
red1
Site Admin
 
Posts: 2760
Joined: Tue Jul 06, 2004 3:01 pm
Location: Kuala Lumpur, Malaysia

Re: Removing original author's name

Postby red1 » Sat Nov 19, 2011 4:09 am

Progressive code review and porting to Jenkins CI server here.
red1
Site Admin
 
Posts: 2760
Joined: Tue Jul 06, 2004 3:01 pm
Location: Kuala Lumpur, Malaysia

Re: Removing original author's name

Postby red1 » Mon Nov 28, 2011 4:21 pm

Finally the ruling elite in ADempiere SF (370) do something about my submission, after a big vote of no confidence against them. But they did not buy the whole story, and left out my most important point here, which is the broken code and loss of previous good research. Ah well, not surprising when foreign inept commercial intentions takes over a project.
red1
Site Admin
 
Posts: 2760
Joined: Tue Jul 06, 2004 3:01 pm
Location: Kuala Lumpur, Malaysia

Re: Removing original author's name

Postby red1 » Thu Jan 12, 2012 5:42 pm

I found this in my mail box at this 5.15am while in bed in Bogota. From the deep research effort, you can easily guess who it is from:
mjmckay say:
"For the ID generator, I reverted the code in 3.7 to the previous version"
https://sourceforge.net/projects/adempi ... e=11009247

After that tobi42 says:
"Teo implemented a little fix to make the ID generator pluggable"
https://sourceforge.net/projects/adempi ... e=11017216
and add some "understandings" trying to play fool ignoring the work from old PMC :-)

Then kthiemann states:
"it would be good if the id of the html element contains the ad_field_id"
https://sourceforge.net/projects/adempi ... e=11017490
asking exactly for what was reverted

Then teo_sarca writes:
"i just introduced flexibility to plug and ZK ID generator"
https://sourceforge.net/projects/adempi ... e=11018272

And to top the thread mjmckay wrote:
"The ID generator code is called at a pretty low level as the webui window is being created. In the previous version of the generator, the code used a property ("zk_component_prefix") of the html component to identify what field the component was referring to. This property was set in the WEditor class (org.adempiere.webui.editor) that applied to the field"
https://sourceforge.net/projects/adempi ... e=11030767
In other words - that approach does not work - the "introduced flexibility" is not solving the problem because the code that did the trick is elsewhere - HAHAHAHA

and after that - OOOOOOPS - silence from tobi and teo

What a circus, all those inventions and work in circles just to avoid accepting that Victor dropped something working and committed shit.

:-D


I feel sad when Carlos related this to me yesterday evening in his car on the way back from his office. But i hope the community out there finds out this truth which can be easily tested live here http://sourceforge.net/projects/red1/ at the Jenkins server under WebUITesting which uses the code old PMC did and yet the present official PMC still struggles to walk backwards and forwards, trampling over perfectly working code, even though i started a big war and a direct IDGenerator class trial right in front of their noses to shout that 'it is already done but Victor reverted!!". So i guess i will stick this photo (that shows a green button for that at the bottom of it) on the wall here to sometimes look at to enjoy what i will call IT artistic value (that comes with this thread and others elsewhere as poetic justice).

JenkinsStack.jpg
JenkinsStack.jpg (72.39 KiB) Viewed 19058 times
red1
Site Admin
 
Posts: 2760
Joined: Tue Jul 06, 2004 3:01 pm
Location: Kuala Lumpur, Malaysia

Re: Removing original author's name

Postby red1 » Thu Jan 12, 2012 6:06 pm

To show you what circus Carlos meant (and pardon my patronising posts here, but i just can't help it as i am not sure if we should all pray and die for our beloved ADempiere), I search the words of McKay in the link above and pasted below:
For the ID generator, I reverted the code in 3.7 to the previous version here http://adempiere.hg.sourceforge.net/hgw ... rator.java.

When you click on the class McKay gave, it leads you to the same IDGenerator class done by former PMC and voila! Carlos Ruiz name is back as the author!
Code: Select all
/******************************************************************************

     2  * Copyright (C) 2010 Carlos Ruiz                                             *

     3  * Copyright (C) 2009 Quality Systems & Solutions - globalqss                 *


(Now you know why so many millions die in senseless wars all over the world?)

I asked Carlos in the car park yesterday, why would they do all this and brought the whole community to its knees? He told me in Spanish accent,"ha.. arrogance, ego...". I disagree with the way Carlos put it. Perhaps that is the difference between him and me which is more English accent and politically correct. I would say it is "thinking too highly of oneself, been highly educated, very professional people who are too busy to see beyond oneself, and probably wish to maintain self esteem at all times so that no one can call them stupid". When i see who should be the author above now as McKay reverted to, i wonder what would happen if i or Carlos just kept quiet. Maybe all the code credit stealing will slowly get reverted. In the end we end up with 361! So the community has nothing to worry, years later. Meanwhile we just focus on iDempiere release. Who knows, one day, they will take it perhaps versions later as ADempiere XVII. :)
red1
Site Admin
 
Posts: 2760
Joined: Tue Jul 06, 2004 3:01 pm
Location: Kuala Lumpur, Malaysia

Re: Removing original author's name

Postby red1 » Sat Feb 25, 2012 3:28 am

What else can a symbiotic role of judge, jury and executioner do but backed out the bus entirely on its own to what it was previously comitted by Carlos Ruiz (but senor Ruiz is already pronounced guilty and executed by summary firing squad - Pow!, Pow!):

Code: Select all
Changeset:   http://adempiere.hg.sourceforge.net:8000/hgroot/adempiere/adempiere/rev/a631b4a85db9
---------
Repository:  adempiere
Branch:      master
Revision:    7006-a631b4a85db9
Parent:      6762:ab2809ed7955
Author:      mjmckay <michael.mckay@sympatico.ca>
Date:        2011-09-07 05:48 -0400

Log Message:
-----------
Backed out changeset: 01919bf50f30

Modified Files:
--------------
/zkwebui/WEB-INF/src/org/adempiere/webui/AdempiereIdGenerator.java

The link above gives below, as a revert, which will now seemed like removing Victor Perez's name! Then what happens to 2 letters from ADempiere senior members to FSF and Potix claiming Victor was right and Carlos was wrong? It has again caused damage and is now utterly confusing for our project:
Code: Select all
     1.1 --- a/zkwebui/WEB-INF/src/org/adempiere/webui/AdempiereIdGenerator.java   Thu Sep 01 14:13:52 2011 -0500
     1.2 +++ b/zkwebui/WEB-INF/src/org/adempiere/webui/AdempiereIdGenerator.java   Wed Sep 07 05:48:05 2011 -0400
     1.3 @@ -1,6 +1,6 @@
     1.4  /******************************************************************************
     1.5 - * Copyright (C) 2011 victor.perez@e-evolution.com                            *
     1.6 - * Copyright (C) 2009 www.e-evolution.com, e-Evolution                         *
     1.7 + * Copyright (C) 2010 Carlos Ruiz                                             *
     1.8 + * Copyright (C) 2009 Quality Systems & Solutions - globalqss                 *
     1.9   * This program is free software; you can redistribute it and/or modify it    *
    1.10   * under the terms version 2 of the GNU General Public License as published   *
    1.11   * by the Free Software Foundation. This program is distributed in the hope   *
    1.12 @@ -19,30 +19,34 @@
    1.13  import org.zkoss.zk.ui.Page;
    1.14  import org.zkoss.zk.ui.sys.IdGenerator;
    1.15 
    1.16 -/**
    1.17 - * PP Product BOM Model.
    1.18 - *
    1.19 - * @author Victor Perez www.e-evolution.com
    1.20 - * http://docs.zkoss.org/wiki/How_to_Test_ZK_Application_with_Selenium
    1.21 - * */

Remember Carlos Ruiz at first raised this to the ruling junta but was ignored, accused of wrongly practice of shouting, and refused a hearing until i raised a call for no confidence on the whole inept lot. Our project has impaired to the lowest indented level possible. Half of the early founding council members are not on this side of Carlos, Alejandro, <name withheld>, and me.
red1
Site Admin
 
Posts: 2760
Joined: Tue Jul 06, 2004 3:01 pm
Location: Kuala Lumpur, Malaysia

Re: Removing original author's name

Postby globalqss » Tue Feb 28, 2012 9:32 am

:-D Not so fast, the backout was backed out :-D

For some people is not easy to recognize facts (they think they lose pride).

I'm eager to see the next shot in the foot :-) Last one, the interface generator didn't work, so let's see what's next step to avoid recognizing the effort from others.

Regards,

Carlos Ruiz
globalqss
Senior
 
Posts: 599
Joined: Thu Dec 29, 2005 4:15 am
Location: Bogotá, Colombia

Re: Removing original author's name

Postby red1 » Thu Mar 01, 2012 5:53 am

Yes it was backed out and it is back to Teo's code. Your name should not be there since its not your work at the moment. I will get confused just reading the authors list. McKay's last comment there is still pending http://sourceforge.net/projects/adempie ... ic/4694931
He said at post 16 that previous one (yours) worked and not the present one. So i am as eager as you are too :)
red1
Site Admin
 
Posts: 2760
Joined: Tue Jul 06, 2004 3:01 pm
Location: Kuala Lumpur, Malaysia


Return to Rants Allowed

Who is online

Users browsing this forum: No registered users and 1 guest

cron