Unable to handle null condition in script callout

[vivekjustthink]

Hi,

For a long time, i am unable to handle null condition in script callout in adempiere. Just take a look at this beanshell script callout.

Script Name : beanshell:AlertProductMaximumLimitExcess

Code: Select all

maximumQty=DB.getSQLValueBD(null, "select level_max from m_replenish where m_product_id=?",mproductid);
if(maximumQty != null && maximumQty!=0 && maximumQty!=-1)
{        if(qty!= 0)       
         {       
               if(qty.compareTo(maximumqty)>0)
                       return Msg.getMsg("en_us",display);
         }
}

what ever the maximum qty is, the code get inside the if condition. i even specified it this way

Code: Select all

maximumQty = null;
if(maximumQty==null){
          return Msg.getMsg("en_us","maximum Qty is null");
}

Thanks for your help..

regards
vivek

[globalqss]

Hi Vivek, can you paste the complete code of the callout? To check how are you initializing the mproductid and qty variables.

Also, if the maximumQty is BigDecimal - then comparing to integer doesn't sound right.

I think also that beanshell has some special management for nulls - AFAIR there is a NULL object - maybe like this:
http://www.beanshell.org/javadoc/bsh/Pr ... .html#NULL

Regards,

Carlos Ruiz

[vivekjustthink]

Thank You so much carloz your hint was just enlightening.

Actually beanshell has the class Primitive as java has the class Object. 2 special fields are in class Primitive. They are NULL & VOID. Void means no data type, but a special type in beanshell and they say it for practical reasons.

In the following way we can handle null or void in beanshell.

Way 1

Code: Select all

qty=null;
if(qty==NULL){
A_Tab.setValue("Description","qty is null");
}else{
A_Tab.setValue("Description","qty is not null");
}

Way 2

Code: Select all

qty=null;
if(qty==VOID){
A_Tab.setValue("Description","qty is null");
}else{
A_Tab.setValue("Description","qty is not null");
}

Hope this is useful for others if they face the same problem. Once again a great thanks to Carlos...

[red1]

Thank you Vivek for rephrasing the answer. This is also helpful to me to learn something i did not know before.

[vivekjustthink]