Centralizing hardcoded ID ?

[nmicoud]

Hi,

A lot of Adempiere classes contain hardcoded ID (eg : AMenu with request window ID, AcctViewerData with PostingType reference, ...)
I'm wondering if it would be better to put them in only one place (a top level class or a textfile) so it would be easier to maintain.

WDYT ?

Regards,

Nicolas

[globalqss]

Excellent idea, I like it, my choice would be a top level class containing the hardcoded IDs as constant.

In case we want to make it parameterizable, I would prefer creating SysConfig variables than a text file.

Regards,

Carlos Ruiz

[nmicoud]

So maybe, the first thing to do is to create a HardcodedID.java and fill it ?

Then after, we could make it parameterizable.

But i 'm not sure that Sysconfig variables are good thing for this.
Maybe we could create a 'AD_HardcodedID' table (not sure that a tablename which finish with 'ID' is a good thing) which contains mandatory columns and AD_Element_ID, AD_Table_ID, ... so that we could store a direct link.

We could have :
Name = PostingType Reference
Type = Reference
AD_Reference_ID = 125 (but we see "_Posting Type_L")

I think it is easier to maintain than just have some "'Constant_Reference_PostingType' = 125" in SysConfig.

WDYT ?

Should i create a jira ticket for this ?

Regards,

Nico